[11] RFR JDK-8196310: jlink --suggest-providers fails with missing resource if --output specified

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[11] RFR JDK-8196310: jlink --suggest-providers fails with missing resource if --output specified

Mandy Chung
Webrev:
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8196310/webrev.00/ 
Improve the error message when invalid argument is specified to
--suggest-providers option. $ jlink --add-modules java.base
--suggest-providers java.security.Provider --output myimage Error:
--suggest-providers does not accept "--output myimage" argument Mandy

Reply | Threaded
Open this post in threaded view
|

Re: [11] RFR JDK-8196310: jlink --suggest-providers fails with missing resource if --output specified

Mandy Chung
(resend with fixed formatting)

Webrev:
    http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8196310/webrev.00/


Improve the error message when invalid argument is specified to
--suggest-providers option.


$ jlink --add-modules java.base --suggest-providers java.security.Provider --output myimage
Error: --suggest-providers does not accept "--output myimage" argument


Mandy

Reply | Threaded
Open this post in threaded view
|

Re: [11] RFR JDK-8196310: jlink --suggest-providers fails with missing resource if --output specified

Lance Andersen
Looks OK Mandy

could also tweak the message to

…does not accept the “-output…”

or

…does not support the “-output…”

Best
Lance

> On Jan 30, 2018, at 7:31 PM, mandy chung <[hidden email]> wrote:
>
> (resend with fixed formatting)
>
> Webrev:
>   http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8196310/webrev.00/
>
>
> Improve the error message when invalid argument is specified to
> --suggest-providers option.
>
>
> $ jlink --add-modules java.base --suggest-providers java.security.Provider --output myimage
> Error: --suggest-providers does not accept "--output myimage" argument
>
>
> Mandy
>

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|

Re: [11] RFR JDK-8196310: jlink --suggest-providers fails with missing resource if --output specified

Sundararajan Athijegannathan
In reply to this post by Mandy Chung
+1

-Sundar

On 31/01/18, 6:01 AM, mandy chung wrote:

> (resend with fixed formatting)
>
> Webrev:
>    http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8196310/webrev.00/
>
>
> Improve the error message when invalid argument is specified to
> --suggest-providers option.
>
>
> $ jlink --add-modules java.base --suggest-providers
> java.security.Provider --output myimage
> Error: --suggest-providers does not accept "--output myimage" argument
>
>
> Mandy
>
Reply | Threaded
Open this post in threaded view
|

Re: [11] RFR JDK-8196310: jlink --suggest-providers fails with missing resource if --output specified

Alan Bateman
In reply to this post by Mandy Chung


On 31/01/2018 00:31, mandy chung wrote:

> (resend with fixed formatting)
>
> Webrev:
> http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8196310/webrev.00/
>
>
> Improve the error message when invalid argument is specified to
> --suggest-providers option.
>
>
> $ jlink --add-modules java.base --suggest-providers
> java.security.Provider --output myimage
> Error: --suggest-providers does not accept "--output myimage" argument
Looks good.
Reply | Threaded
Open this post in threaded view
|

Re: [11] RFR JDK-8196310: jlink --suggest-providers fails with missing resource if --output specified

Mandy Chung
In reply to this post by Lance Andersen
Hi Lance,

--suggest-providers takes an optional argument (comma-separated list
of service types) and anything following it is not accepted.
So "does not accept" is appropriate in this error message.

Mandy

On 1/30/18 5:09 PM, Lance Andersen wrote:

> Looks OK Mandy
>
> could also tweak the message to
>
> …does not accept *the* “-output…”
>
> or
>
> …does not *support* *the* “-output…”
>
> Best
> Lance
>> On Jan 30, 2018, at 7:31 PM, mandy chung <[hidden email]
>> <mailto:[hidden email]>> wrote:
>>
>> (resend with fixed formatting)
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8196310/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Emchung/jdk11/webrevs/8196310/webrev.00/>
>>
>>
>> Improve the error message when invalid argument is specified to
>> --suggest-providers option.
>>
>>
>> $ jlink --add-modules java.base --suggest-providers
>> java.security.Provider --output myimage
>> Error: --suggest-providers does not accept "--output myimage" argument
>>
>>
>> Mandy
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> [hidden email] <mailto:[hidden email]>
>
>
>