RFR: 8201794: [Graal] add dummy HotSpotGraalManagement class

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8201794: [Graal] add dummy HotSpotGraalManagement class

Doug Simon
Right after pushing the change for JDK-8187490, I noticed that the mach5 build had 2 CTW test failures due to jdk.internal.vm.compiler.management now being an empty module. This will be fixed in the next Graal update but the failing tests should be fixed in the meantime.

http://cr.openjdk.java.net/~dnsimon/8201794/
https://bugs.openjdk.java.net/browse/JDK-8201794

I'm running mach5 now to ensure the regressions are fixed and no other regressions occur.

-Doug
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8201794: [Graal] fix regressions from JDK-8187490

Doug Simon
I've updated the webrev with a fix for another regression caused by JDK-8187490:

--- old/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
+++ new/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
@@ -46,6 +46,7 @@
         List.of("java.compiler",
                 "java.jnlp",
                 "jdk.internal.vm.compiler",
+                "jdk.internal.vm.compiler.management",
                 "jdk.deploy",
                 "jdk.javaws",
                 "jdk.plugin",

-Doug

> On 18 Apr 2018, at 12:35, Doug Simon <[hidden email]> wrote:
>
> Right after pushing the change for JDK-8187490, I noticed that the mach5 build had 2 CTW test failures due to jdk.internal.vm.compiler.management now being an empty module. This will be fixed in the next Graal update but the failing tests should be fixed in the meantime.
>
> http://cr.openjdk.java.net/~dnsimon/8201794/
> https://bugs.openjdk.java.net/browse/JDK-8201794
>
> I'm running mach5 now to ensure the regressions are fixed and no other regressions occur.
>
> -Doug

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8201794: [Graal] fix regressions from JDK-8187490

Mandy Chung
Looks okay.  Have you run all jdk_core tests in addition to other
hotspot tests.

Mandy

On 4/18/18 7:00 PM, Doug Simon wrote:

> I've updated the webrev with a fix for another regression caused by JDK-8187490:
>
> --- old/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
> +++ new/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
> @@ -46,6 +46,7 @@
>           List.of("java.compiler",
>                   "java.jnlp",
>                   "jdk.internal.vm.compiler",
> +                "jdk.internal.vm.compiler.management",
>                   "jdk.deploy",
>                   "jdk.javaws",
>                   "jdk.plugin",
>
> -Doug
>
>> On 18 Apr 2018, at 12:35, Doug Simon <[hidden email]> wrote:
>>
>> Right after pushing the change for JDK-8187490, I noticed that the mach5 build had 2 CTW test failures due to jdk.internal.vm.compiler.management now being an empty module. This will be fixed in the next Graal update but the failing tests should be fixed in the meantime.
>>
>> http://cr.openjdk.java.net/~dnsimon/8201794/
>> https://bugs.openjdk.java.net/browse/JDK-8201794
>>
>> I'm running mach5 now to ensure the regressions are fixed and no other regressions occur.
>>
>> -Doug

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8201794: [Graal] fix regressions from JDK-8187490

Doug Simon


> On 18 Apr 2018, at 13:23, mandy chung <[hidden email]> wrote:
>
> Looks okay.  Have you run all jdk_core tests in addition to other hotspot tests.

I ran all open/test/jdk/jdk tests - is that what you mean?

-Doug

> On 4/18/18 7:00 PM, Doug Simon wrote:
>> I've updated the webrev with a fix for another regression caused by JDK-8187490:
>>
>> --- old/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
>> +++ new/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
>> @@ -46,6 +46,7 @@
>>          List.of("java.compiler",
>>                  "java.jnlp",
>>                  "jdk.internal.vm.compiler",
>> +                "jdk.internal.vm.compiler.management",
>>                  "jdk.deploy",
>>                  "jdk.javaws",
>>                  "jdk.plugin",
>>
>> -Doug
>>
>>
>>> On 18 Apr 2018, at 12:35, Doug Simon <[hidden email]>
>>>  wrote:
>>>
>>> Right after pushing the change for JDK-8187490, I noticed that the mach5 build had 2 CTW test failures due to jdk.internal.vm.compiler.management now being an empty module. This will be fixed in the next Graal update but the failing tests should be fixed in the meantime.
>>>
>>>
>>> http://cr.openjdk.java.net/~dnsimon/8201794/
>>> https://bugs.openjdk.java.net/browse/JDK-8201794
>>>
>>>
>>> I'm running mach5 now to ensure the regressions are fixed and no other regressions occur.
>>>
>>> -Doug
>>>
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8201794: [Graal] fix regressions from JDK-8187490

Alan Bateman
In reply to this post by Doug Simon
On 18/04/2018 12:00, Doug Simon wrote:

> I've updated the webrev with a fix for another regression caused by JDK-8187490:
>
> --- old/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
> +++ new/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
> @@ -46,6 +46,7 @@
>           List.of("java.compiler",
>                   "java.jnlp",
>                   "jdk.internal.vm.compiler",
> +                "jdk.internal.vm.compiler.management",
>                   "jdk.deploy",
>                   "jdk.javaws",
>                   "jdk.plugin",
>
This looks fine, this seems to be the only jdk_core test failing after
JDK-8187490.

-Alan