RFR: 8202810: Remove class-for-name test

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8202810: Remove class-for-name test

Claes Redestad
Hi,

please review the removal of this test that explicitly attempts to run
the now removed jlink --class-for-name plugin:

diff -r 7f05a1e6a02a test/jdk/tools/jlink/JLinkPluginsTest.java
--- a/test/jdk/tools/jlink/JLinkPluginsTest.java    Tue May 08 15:42:19
2018 +0200
+++ b/test/jdk/tools/jlink/JLinkPluginsTest.java    Tue May 08 22:46:14
2018 +0200
@@ -77,14 +77,6 @@
              helper.checkImage(imageDir, moduleName, res, null);
          }
          {
-            // Optimize Class.forName
-            String[] userOptions = {"--class-for-name"};
-            String moduleName = "classforname";
-            helper.generateDefaultJModule(moduleName, "composite2");
-            Path imageDir = helper.generateDefaultImage(userOptions,
moduleName).assertSuccess();
-            helper.checkImage(imageDir, moduleName, null, null);
-        }
-        {
              // disable generate jli classes - JDK-8160063
              String[] userOptions = {"--disable-plugin",
"generate-jli-classes"};
              String moduleName = "jlidisabled";

/Claes
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8202810: Remove class-for-name test

Mandy Chung
+1

I checked and this is the only test needed update.

Mandy

On 5/8/18 1:45 PM, Claes Redestad wrote:

> Hi,
>
> please review the removal of this test that explicitly attempts to run
> the now removed jlink --class-for-name plugin:
>
> diff -r 7f05a1e6a02a test/jdk/tools/jlink/JLinkPluginsTest.java
> --- a/test/jdk/tools/jlink/JLinkPluginsTest.java    Tue May 08
> 15:42:19 2018 +0200
> +++ b/test/jdk/tools/jlink/JLinkPluginsTest.java    Tue May 08
> 22:46:14 2018 +0200
> @@ -77,14 +77,6 @@
>              helper.checkImage(imageDir, moduleName, res, null);
>          }
>          {
> -            // Optimize Class.forName
> -            String[] userOptions = {"--class-for-name"};
> -            String moduleName = "classforname";
> -            helper.generateDefaultJModule(moduleName, "composite2");
> -            Path imageDir = helper.generateDefaultImage(userOptions,
> moduleName).assertSuccess();
> -            helper.checkImage(imageDir, moduleName, null, null);
> -        }
> -        {
>              // disable generate jli classes - JDK-8160063
>              String[] userOptions = {"--disable-plugin",
> "generate-jli-classes"};
>              String moduleName = "jlidisabled";
>
> /Claes

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8202810: Remove class-for-name test

Jim Laskey (Oracle)
In reply to this post by Claes Redestad
+1

Sent from my iPhone

> On May 8, 2018, at 5:45 PM, Claes Redestad <[hidden email]> wrote:
>
> Hi,
>
> please review the removal of this test that explicitly attempts to run the now removed jlink --class-for-name plugin:
>
> diff -r 7f05a1e6a02a test/jdk/tools/jlink/JLinkPluginsTest.java
> --- a/test/jdk/tools/jlink/JLinkPluginsTest.java    Tue May 08 15:42:19 2018 +0200
> +++ b/test/jdk/tools/jlink/JLinkPluginsTest.java    Tue May 08 22:46:14 2018 +0200
> @@ -77,14 +77,6 @@
>              helper.checkImage(imageDir, moduleName, res, null);
>          }
>          {
> -            // Optimize Class.forName
> -            String[] userOptions = {"--class-for-name"};
> -            String moduleName = "classforname";
> -            helper.generateDefaultJModule(moduleName, "composite2");
> -            Path imageDir = helper.generateDefaultImage(userOptions, moduleName).assertSuccess();
> -            helper.checkImage(imageDir, moduleName, null, null);
> -        }
> -        {
>              // disable generate jli classes - JDK-8160063
>              String[] userOptions = {"--disable-plugin", "generate-jli-classes"};
>              String moduleName = "jlidisabled";
>
> /Claes

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8202810: Remove class-for-name test

Claes Redestad
Mandy, Jim, thanks for the quick reviews. Pushed.

/Claes

On 2018-05-08 22:56, James Laskey wrote:

> +1
>
> Sent from my iPhone
>
>> On May 8, 2018, at 5:45 PM, Claes Redestad <[hidden email]> wrote:
>>
>> Hi,
>>
>> please review the removal of this test that explicitly attempts to run the now removed jlink --class-for-name plugin:
>>
>> diff -r 7f05a1e6a02a test/jdk/tools/jlink/JLinkPluginsTest.java
>> --- a/test/jdk/tools/jlink/JLinkPluginsTest.java    Tue May 08 15:42:19 2018 +0200
>> +++ b/test/jdk/tools/jlink/JLinkPluginsTest.java    Tue May 08 22:46:14 2018 +0200
>> @@ -77,14 +77,6 @@
>>               helper.checkImage(imageDir, moduleName, res, null);
>>           }
>>           {
>> -            // Optimize Class.forName
>> -            String[] userOptions = {"--class-for-name"};
>> -            String moduleName = "classforname";
>> -            helper.generateDefaultJModule(moduleName, "composite2");
>> -            Path imageDir = helper.generateDefaultImage(userOptions, moduleName).assertSuccess();
>> -            helper.checkImage(imageDir, moduleName, null, null);
>> -        }
>> -        {
>>               // disable generate jli classes - JDK-8160063
>>               String[] userOptions = {"--disable-plugin", "generate-jli-classes"};
>>               String moduleName = "jlidisabled";
>>
>> /Claes