RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

sundararajan.athijegannathan
Reply | Threaded
Open this post in threaded view
|

Re: RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

Jim Laskey (Oracle)
+1


> On May 27, 2019, at 6:18 AM, Sundararajan Athijegannathan <[hidden email]> wrote:
>
> Please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8216553
> Webrev: https://cr.openjdk.java.net/~sundar/8216553/webrev.00/
>
> Thanks,
> -Sundar
>
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

Alan Bateman
In reply to this post by sundararajan.athijegannathan
On 27/05/2019 10:18, Sundararajan Athijegannathan wrote:
> Please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8216553
> Webrev: https://cr.openjdk.java.net/~sundar/8216553/webrev.00/
This addresses the points we discussed in the JIRA issue so I think it
looks good.

-Alan
Reply | Threaded
Open this post in threaded view
|

Re: RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

sundararajan.athijegannathan
Updated for java test failures:

https://cr.openjdk.java.net/~sundar/8216553/webrev.01/

PS. Test framework used wrong jrt: URI pattern. Fixed it.

-Sundar

On 27/05/19, 5:37 PM, Alan Bateman wrote:
> On 27/05/2019 10:18, Sundararajan Athijegannathan wrote:
>> Please review.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8216553
>> Webrev: https://cr.openjdk.java.net/~sundar/8216553/webrev.00/
> This addresses the points we discussed in the JIRA issue so I think it
> looks good.
>
> -Alan
Reply | Threaded
Open this post in threaded view
|

Re: RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

Jim Laskey (Oracle)
+1

> On May 28, 2019, at 6:48 AM, Sundararajan Athijegannathan <[hidden email]> wrote:
>
> Updated for java test failures:
>
> https://cr.openjdk.java.net/~sundar/8216553/webrev.01/
>
> PS. Test framework used wrong jrt: URI pattern. Fixed it.
>
> -Sundar
>
> On 27/05/19, 5:37 PM, Alan Bateman wrote:
>> On 27/05/2019 10:18, Sundararajan Athijegannathan wrote:
>>> Please review.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8216553
>>> Webrev: https://cr.openjdk.java.net/~sundar/8216553/webrev.00/
>> This addresses the points we discussed in the JIRA issue so I think it looks good.
>>
>> -Alan