RFR 8222098: tools/jlink/plugins/IncludeLocalesPluginTest.java time out

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR 8222098: tools/jlink/plugins/IncludeLocalesPluginTest.java time out

sundararajan.athijegannathan
Please review.

Not really a fix - but increasing the default timeout for the test.

Bug: https://bugs.openjdk.java.net/browse/JDK-8222098

Webrev: http://cr.openjdk.java.net/~sundar/8222098/webrev.00/

Thanks,

-Sundar

Reply | Threaded
Open this post in threaded view
|

Re: RFR 8222098: tools/jlink/plugins/IncludeLocalesPluginTest.java time out

sundararajan.athijegannathan
Adding core-libs-dev.

-Sundar

On 10/01/20 11:33 am, [hidden email] wrote:

> Please review.
>
> Not really a fix - but increasing the default timeout for the test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222098
>
> Webrev: http://cr.openjdk.java.net/~sundar/8222098/webrev.00/
>
> Thanks,
>
> -Sundar
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR 8222098: tools/jlink/plugins/IncludeLocalesPluginTest.java time out

Jim Laskey (Oracle)
In reply to this post by sundararajan.athijegannathan
+1

> On Jan 10, 2020, at 2:03 AM, [hidden email] wrote:
>
> Please review.
>
> Not really a fix - but increasing the default timeout for the test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222098
>
> Webrev: http://cr.openjdk.java.net/~sundar/8222098/webrev.00/
>
> Thanks,
>
> -Sundar
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR 8222098: tools/jlink/plugins/IncludeLocalesPluginTest.java time out

Naoto Sato
In reply to this post by sundararajan.athijegannathan
Hi Sundar,

You might want to add the bug id in the regression test, and change the
copyright year to 2020.

Otherwise, looks good.

Naoto

On 1/10/20 5:07 AM, [hidden email] wrote:

> Adding core-libs-dev.
>
> -Sundar
>
> On 10/01/20 11:33 am, [hidden email] wrote:
>> Please review.
>>
>> Not really a fix - but increasing the default timeout for the test.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8222098
>>
>> Webrev: http://cr.openjdk.java.net/~sundar/8222098/webrev.00/
>>
>> Thanks,
>>
>> -Sundar
>>
Reply | Threaded
Open this post in threaded view
|

Re: RFR 8222098: tools/jlink/plugins/IncludeLocalesPluginTest.java time out

sundararajan.athijegannathan
Hi Naoto,

Thanks. I'll make those changes and push.

-Sundar

On 10/01/20 7:20 pm, [hidden email] wrote:

> Hi Sundar,
>
> You might want to add the bug id in the regression test, and change
> the copyright year to 2020.
>
> Otherwise, looks good.
>
> Naoto
>
> On 1/10/20 5:07 AM, [hidden email] wrote:
>> Adding core-libs-dev.
>>
>> -Sundar
>>
>> On 10/01/20 11:33 am, [hidden email] wrote:
>>> Please review.
>>>
>>> Not really a fix - but increasing the default timeout for the test.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8222098
>>>
>>> Webrev: http://cr.openjdk.java.net/~sundar/8222098/webrev.00/
>>>
>>> Thanks,
>>>
>>> -Sundar
>>>