RFR - JImageListTest test fix

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR - JImageListTest test fix

Michal Vala
Hi,

sending patch fixing JImageListTest failing tests. It was in ProblemList and
this fix greens the test case, so the patch also removes it from the list.
It will probably need new bug id and I will need a sponsor for this.

Fix itself is simple. There was incorrect assert for list of images contains
java.base image as it was testing index of "java.base" > 0 and it's usually at
first place, thus index 0. I've changed it to List#contains.

Thanks!

--
Michal Vala
OpenJDK QE
Red Hat Czech

jdk.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: RFR - JImageListTest test fix

Alan Bateman
On 19/02/2018 14:51, Michal Vala wrote:

> Hi,
>
> sending patch fixing JImageListTest failing tests. It was in
> ProblemList and this fix greens the test case, so the patch also
> removes it from the list.
> It will probably need new bug id and I will need a sponsor for this.
>
> Fix itself is simple. There was incorrect assert for list of images
> contains java.base image as it was testing index of "java.base" > 0
> and it's usually at first place, thus index 0. I've changed it to
> List#contains.
This looks okay to me.

-Alan
Reply | Threaded
Open this post in threaded view
|

Re: RFR - JImageListTest test fix

Alan Bateman
In reply to this post by Michal Vala


On 19/02/2018 14:51, Michal Vala wrote:
> Hi,
>
> sending patch fixing JImageListTest failing tests. It was in
> ProblemList and this fix greens the test case, so the patch also
> removes it from the list.
These tests are failing on Windows now. Nothing to do with your changes,
it seems the original tests added via JDK-8167240 weren't run enough to
shake out issues with the tests. So we need to re-add them to the
exclude list, Sundar has already reviewed.

-Alan

diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txt
+++ b/test/jdk/ProblemList.txt
@@ -464,6 +464,9 @@

  tools/launcher/FXLauncherTest.java 8068049 linux-all,macosx-all

+tools/jimage/JImageExtractTest.java 8198405 windows-all
+tools/jimage/JImageListTest.java 8198405 windows-all
+
  ############################################################################


Reply | Threaded
Open this post in threaded view
|

Re: RFR - JImageListTest test fix

Michal Vala


On 02/20/2018 10:47 AM, Alan Bateman wrote:

>
>
> On 19/02/2018 14:51, Michal Vala wrote:
>> Hi,
>>
>> sending patch fixing JImageListTest failing tests. It was in ProblemList and
>> this fix greens the test case, so the patch also removes it from the list.
> These tests are failing on Windows now. Nothing to do with your changes, it
> seems the original tests added via JDK-8167240 weren't run enough to shake out
> issues with the tests. So we need to re-add them to the exclude list, Sundar has
> already reviewed.

ok, I can take a look at them

>
> -Alan
>
> diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt
> --- a/test/jdk/ProblemList.txt
> +++ b/test/jdk/ProblemList.txt
> @@ -464,6 +464,9 @@
>
>   tools/launcher/FXLauncherTest.java 8068049 linux-all,macosx-all
>
> +tools/jimage/JImageExtractTest.java 8198405 windows-all
> +tools/jimage/JImageListTest.java 8198405 windows-all
> +
>   ############################################################################
>
>

--
Michal Vala
OpenJDK QE
Red Hat Czech