Re: Request Review JDK-8180574: tools/launcher/modules/patch/systemmodules/PatchSystemModules.java failed in upgradeHashedModule() and patchHashedModule() intermittently

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Request Review JDK-8180574: tools/launcher/modules/patch/systemmodules/PatchSystemModules.java failed in upgradeHashedModule() and patchHashedModule() intermittently

Alan Bateman
On 26/05/2017 19:17, Mandy Chung wrote:

> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180574/webrev.00/
>
> The test fails intermittently that the hash of new_m1.jar might be the
> same value as m1.jar that is hashed in m2.  Unfortunately I haven’t
> managed to reproduce the test failure with my instrumented test to
> confirm.  I propose to change the test to upgrade a different version
> of m1 rather than the same content and observe if this test would
> fail again.
>
Changing the test to use a different version of m1 make sense, the
changes look okay to me.

-Alan