Review Request 8205112: Remove non-existent modules from test/jdk/jdk/modules/etc/UpgradeableModules.java

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request 8205112: Remove non-existent modules from test/jdk/jdk/modules/etc/UpgradeableModules.java

Mandy Chung
This patch cleans up the list of upgradeable modules kept in
test/jdk/jdk/modules/etc/UpgradeableModules.java test verification and
take out the modules that have been removed.

thanks
Mandy

--- a/test/jdk/jdk/modules/etc/UpgradeableModules.java
+++ b/test/jdk/jdk/modules/etc/UpgradeableModules.java
@@ -44,14 +44,8 @@
  public class UpgradeableModules {
      private static final List<String> UPGRADEABLE_MODULES =
          List.of("java.compiler",
-                "java.jnlp",
                  "jdk.internal.vm.compiler",
-                "jdk.internal.vm.compiler.management",
-                "jdk.deploy",
-                "jdk.javaws",
-                "jdk.plugin",
-                "jdk.plugin.dom"
-                );
+                "jdk.internal.vm.compiler.management");

      public static void main(String... args) {
          Set<String> hashedModules = hashedModules();
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 8205112: Remove non-existent modules from test/jdk/jdk/modules/etc/UpgradeableModules.java

Lance Andersen
+1

> On Jun 15, 2018, at 12:12 PM, mandy chung <[hidden email]> wrote:
>
> This patch cleans up the list of upgradeable modules kept in test/jdk/jdk/modules/etc/UpgradeableModules.java test verification and take out the modules that have been removed.
>
> thanks
> Mandy
>
> --- a/test/jdk/jdk/modules/etc/UpgradeableModules.java
> +++ b/test/jdk/jdk/modules/etc/UpgradeableModules.java
> @@ -44,14 +44,8 @@
> public class UpgradeableModules {
>     private static final List<String> UPGRADEABLE_MODULES =
>         List.of("java.compiler",
> -                "java.jnlp",
>                 "jdk.internal.vm.compiler",
> -                "jdk.internal.vm.compiler.management",
> -                "jdk.deploy",
> -                "jdk.javaws",
> -                "jdk.plugin",
> -                "jdk.plugin.dom"
> -                );
> +                "jdk.internal.vm.compiler.management");
>
>     public static void main(String... args) {
>         Set<String> hashedModules = hashedModules();

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|

Re: Review Request 8205112: Remove non-existent modules from test/jdk/jdk/modules/etc/UpgradeableModules.java

Kevin Rushforth
In reply to this post by Mandy Chung
Looks good to me.

-- Kevin


On 6/15/2018 9:12 AM, mandy chung wrote:

> This patch cleans up the list of upgradeable modules kept in
> test/jdk/jdk/modules/etc/UpgradeableModules.java test verification and
> take out the modules that have been removed.
>
> thanks
> Mandy
>
> --- a/test/jdk/jdk/modules/etc/UpgradeableModules.java
> +++ b/test/jdk/jdk/modules/etc/UpgradeableModules.java
> @@ -44,14 +44,8 @@
>  public class UpgradeableModules {
>      private static final List<String> UPGRADEABLE_MODULES =
>          List.of("java.compiler",
> -                "java.jnlp",
>                  "jdk.internal.vm.compiler",
> -                "jdk.internal.vm.compiler.management",
> -                "jdk.deploy",
> -                "jdk.javaws",
> -                "jdk.plugin",
> -                "jdk.plugin.dom"
> -                );
> +                "jdk.internal.vm.compiler.management");
>
>      public static void main(String... args) {
>          Set<String> hashedModules = hashedModules();

Reply | Threaded
Open this post in threaded view
|

Re: Review Request 8205112: Remove non-existent modules from test/jdk/jdk/modules/etc/UpgradeableModules.java

Alan Bateman
In reply to this post by Mandy Chung


On 15/06/2018 17:12, mandy chung wrote:
> This patch cleans up the list of upgradeable modules kept in
> test/jdk/jdk/modules/etc/UpgradeableModules.java test verification and
> take out the modules that have been removed.
Looks okay to me.

-Alan