Review Request 8240910: jmod rejects duplicate entries in --class-path jars

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request 8240910: jmod rejects duplicate entries in --class-path jars

Mandy Chung
jmod tool should ignore duplicated resources from class path and emit a
warning.  It currently ignores duplicated resources when read from a
directory but not from JAR entries.  It's an oversight from the fix for
JDK-8134779 [1]

http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240910/webrev.00/

This is a simple fix applying the same fix for JDK-8134779 to ignore
duplicated entries processed from a JAR file.

Thanks
Mandy
[1] https://bugs.openjdk.java.net/browse/JDK-8134779
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 8240910: jmod rejects duplicate entries in --class-path jars

Lance Andersen
+1

> On May 7, 2020, at 1:12 PM, Mandy Chung <[hidden email]> wrote:
>
> jmod tool should ignore duplicated resources from class path and emit a warning.  It currently ignores duplicated resources when read from a directory but not from JAR entries.  It's an oversight from the fix for JDK-8134779 [1]
>
> http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240910/webrev.00/
>
> This is a simple fix applying the same fix for JDK-8134779 to ignore duplicated entries processed from a JAR file.
>
> Thanks
> Mandy
> [1] https://bugs.openjdk.java.net/browse/JDK-8134779

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|

Re: Review Request 8240910: jmod rejects duplicate entries in --class-path jars

Mandy Chung
In reply to this post by Mandy Chung
I have taken a further step to clean this up by recording the written
entries such that it can filter out duplicated entries properly:

http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240910/webrev.01/

thanks
Mandy

On 5/7/20 10:12 AM, Mandy Chung wrote:

> jmod tool should ignore duplicated resources from class path and emit
> a warning.  It currently ignores duplicated resources when read from a
> directory but not from JAR entries.  It's an oversight from the fix
> for JDK-8134779 [1]
>
> http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240910/webrev.00/
>
> This is a simple fix applying the same fix for JDK-8134779 to ignore
> duplicated entries processed from a JAR file.
>
> Thanks
> Mandy
> [1] https://bugs.openjdk.java.net/browse/JDK-8134779

Reply | Threaded
Open this post in threaded view
|

Re: Review Request 8240910: jmod rejects duplicate entries in --class-path jars

Alan Bateman
On 07/05/2020 19:39, Mandy Chung wrote:
> I have taken a further step to clean this up by recording the written
> entries such that it can filter out duplicated entries properly:
>
> http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240910/webrev.01/
This version looks okay to me as it cleans up the original code for the
exploded case too.

-Alan
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 8240910: jmod rejects duplicate entries in --class-path jars

Lance Andersen
In reply to this post by Mandy Chung
Hi Mandy,

The extra updates look good.  Thank you for adding the additional clean up!

Best
Lance

> On May 7, 2020, at 2:39 PM, Mandy Chung <[hidden email]> wrote:
>
> I have taken a further step to clean this up by recording the written entries such that it can filter out duplicated entries properly:
>
> http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240910/webrev.01/
>
> thanks
> Mandy
>
> On 5/7/20 10:12 AM, Mandy Chung wrote:
>> jmod tool should ignore duplicated resources from class path and emit a warning.  It currently ignores duplicated resources when read from a directory but not from JAR entries.  It's an oversight from the fix for JDK-8134779 [1]
>>
>> http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240910/webrev.00/
>>
>> This is a simple fix applying the same fix for JDK-8134779 to ignore duplicated entries processed from a JAR file.
>>
>> Thanks
>> Mandy
>> [1] https://bugs.openjdk.java.net/browse/JDK-8134779
>

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>