Review Request JDK-8200121: Remove unused qualified exports in java.base

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request JDK-8200121: Remove unused qualified exports in java.base

Mandy Chung
A simple cleanup to remove unused qualified exports in java.base.

The webrev also includes a fix for JDK-8205116 (jdeps --system
$java.home fails) that I uncovered through this process where I ran
`jdeps --check java.base --system $java.home` on the JDK binaries on
several platforms.

Webrev at:
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8200121/webrev.00/

Mandy
Reply | Threaded
Open this post in threaded view
|

Re: Review Request JDK-8200121: Remove unused qualified exports in java.base

Lance Andersen
Hi Mandy,

The changes look good

Best
Lance
> On Jun 15, 2018, at 12:34 PM, mandy chung <[hidden email]> wrote:
>
> JDK-8205116

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|

Re: Review Request JDK-8200121: Remove unused qualified exports in java.base

Alan Bateman
In reply to this post by Mandy Chung
On 15/06/2018 17:34, mandy chung wrote:
> A simple cleanup to remove unused qualified exports in java.base.
>
> The webrev also includes a fix for JDK-8205116 (jdeps --system
> $java.home fails) that I uncovered through this process where I ran
> `jdeps --check java.base --system $java.home` on the JDK binaries on
> several platforms.
>
> Webrev at:
> http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8200121/webrev.00/
Looks good.

-Alan
Reply | Threaded
Open this post in threaded view
|

Re: Review Request JDK-8200121: Remove unused qualified exports in java.base

Mandy Chung
Alan, Lance,

I added a test case for JDK-8205116 in
test/langtools/tools/jdeps/Options.java.

Updated webrev for JDK-8205116 only:
    http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205116/webrev.01/

Mandy

On 6/15/18 10:47 AM, Alan Bateman wrote:

> On 15/06/2018 17:34, mandy chung wrote:
>> A simple cleanup to remove unused qualified exports in java.base.
>>
>> The webrev also includes a fix for JDK-8205116 (jdeps --system
>> $java.home fails) that I uncovered through this process where I ran
>> `jdeps --check java.base --system $java.home` on the JDK binaries on
>> several platforms.
>>
>> Webrev at:
>> http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8200121/webrev.00/
> Looks good.
>
> -Alan
Reply | Threaded
Open this post in threaded view
|

Re: Review Request JDK-8200121: Remove unused qualified exports in java.base

Lance Andersen
Hi Mandy

The test that was added seems fine.

Best
Lance

> On Jun 15, 2018, at 3:14 PM, mandy chung <[hidden email]> wrote:
>
> Alan, Lance,
>
> I added a test case for JDK-8205116 in test/langtools/tools/jdeps/Options.java.
>
> Updated webrev for JDK-8205116 only:
>   http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205116/webrev.01/
>
> Mandy
>
> On 6/15/18 10:47 AM, Alan Bateman wrote:
>> On 15/06/2018 17:34, mandy chung wrote:
>>> A simple cleanup to remove unused qualified exports in java.base.
>>>
>>> The webrev also includes a fix for JDK-8205116 (jdeps --system $java.home fails) that I uncovered through this process where I ran `jdeps --check java.base --system $java.home` on the JDK binaries on several platforms.
>>>
>>> Webrev at:
>>> http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8200121/webrev.00/
>> Looks good.
>> -Alan

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|

Re: Review Request JDK-8200121: Remove unused qualified exports in java.base

Alan Bateman
In reply to this post by Mandy Chung


On 15/06/2018 20:14, mandy chung wrote:
> Alan, Lance,
>
> I added a test case for JDK-8205116 in
> test/langtools/tools/jdeps/Options.java.
>
> Updated webrev for JDK-8205116 only:
> http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205116/webrev.01/
This looks okay (although "valid $java.home" should be "valid path").

-Alan
Reply | Threaded
Open this post in threaded view
|

Re: Review Request JDK-8200121: Remove unused qualified exports in java.base

Mandy Chung


On 6/15/18 12:45 PM, Alan Bateman wrote:

>
>
> On 15/06/2018 20:14, mandy chung wrote:
>> Alan, Lance,
>>
>> I added a test case for JDK-8205116 in
>> test/langtools/tools/jdeps/Options.java.
>>
>> Updated webrev for JDK-8205116 only:
>> http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205116/webrev.01/
> This looks okay (although "valid $java.home" should be "valid path").

Fixed.

Mandy